[PATCH] Fix Shark build in JDK9

David Holmes david.holmes at oracle.com
Thu Jan 8 02:12:44 UTC 2015

On 8/01/2015 1:10 AM, Erik Joelsson wrote:
> Hello,
> On 2015-01-07 15:45, Roman Kennke wrote:
>> Hello there,
>> I made some fixes to the build machinery to be able to build Shark:
>> http://cr.openjdk.java.net/~rkennke/shark-build-top/
> Looks fine, but the generated configure script needs to be generated by
> the script as it also updates a timestamp inside the file. We will still
> need to update the closed version of the generated script in sync with
> this. I will be happy to push both when review has passed if you like.
>> http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/
> That looks like a simple typo. Looks good to me. This is in hotspot
> however so will need to go through a hotspot forest and requires 2
> reviewers.

I think this is trivial enough that it doesn't matter which forest it 
goes through - better to keep everything in one forest though. I can add 
my Review to Eriks and that will suffice.


>> http://cr.openjdk.java.net/~rkennke/shark-build-jdk/
> Is the contents of the conditionals for SERVER, ZERO and ZEROSHARK the
> exact same? Perhaps change into one conditional like this?
> ifneq ($(findstring $(JVM_VARIANTS), server zero zeroshark),)
> I'm also pondering if the build_sa conditional could be made simpler,
> but this is planned to go away before JDK 9 is done so I'm ok with
> leaving it like this.
>> In particular, it does:
>> - Improve the sed command to figure out the LLVM version. LLVM changed
>> its version string from x.y to x.y.z. The command now correctly strips
>> x.y.z to xy, we're only interested in the first two numbers. I also
>> hand-changed the generated configure, please forgive me ;-)
>> - In hotspot's makefile, I fixed a typo, allowing to build with unzipped
>> debug info.
>> - In JDK's build, I added the ZEROSHARK variant to exclude the SA
>> generation.
>> Notice that this alone doesn't make Shark build and run fine, it still
>> requires some code changes. Those are not related to build-dev though, I
>> will post them to the appropriate lists asap.
>> Can you please review the changes? I would like to push this to
>> build-infra/jdk9.
> Build changes go directly to jdk9/dev. The build-infra forest is for
> prototyping things for the build-infra project and has no scheduled
> pushes to jdk9. Perhaps it would be better to combine the above changes
> with your source changes and submit reviews separately for hotspot and
> root/jdk repos instead?
> /Erik
>> Regards,
>> Roman

More information about the build-dev mailing list