RFR: JDK-8068735 Configure fails on Windows if Visual Studio $LIB/$INCLUDE is lower case

Erik Joelsson erik.joelsson at oracle.com
Fri Jan 9 15:44:50 UTC 2015

Looks ok to me.


On 2015-01-09 16:41, Magnus Ihse Bursie wrote:
> When detecting the Visual Studio environment, we check for the 
> variables $LIB and $INCLUDE. However, on Windows, environment 
> variables are not case sensitive.
> Most of the time, these are named $LIB and $INCLUDE, but sometimes 
> they are named $lib and $include instead. Currently, we fail if this 
> is the case.
> I made a simple fix to cover this case. Ideally, we'd like to have 
> proper, full support of case insensitivity. Unfortunately, that is 
> hard to fix and the current lines are the result of much blood and 
> tears. I'm not very much inclined to try to "improve" them.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8068735
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8068735-support-lowercase-vs-env/webrev.01
> /Magnus

More information about the build-dev mailing list