JDK 9 RFR of JDK-8067099: Add deprecation lint warning to build of jdk repository
joe.darcy at oracle.com
Sat Jan 10 00:55:07 UTC 2015
Catching up on email after the holidays...
On 12/9/2014 10:39 PM, Erik Joelsson wrote:
> First, congratulations on almost being done fixing all the warnings!
> When removing the last warning exception, perhaps it's time to change
> the comment next to this line too?
A fair point!
--- old/make/common/SetupJavaCompilers.gmk 2015-01-09
+++ new/make/common/SetupJavaCompilers.gmk 2015-01-09
@@ -1,5 +1,5 @@
-# Copyright (c) 2011, 2014, Oracle and/or its affiliates. All rights
+# Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
# This code is free software; you can redistribute it and/or modify it
@@ -30,9 +30,9 @@
-# To build with all warnings enabled, do the following:
+# If warnings needs to be non-fatal for testing purposes use a command
# make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
-JAVAC_WARNINGS := -Xlint:all,-deprecation -Werror
+JAVAC_WARNINGS := -Xlint:all -Werror
# The BOOT_JAVAC setup uses the boot jdk compiler to compile the tools
# and the interim javac, to be run by the boot jdk.
(Also viewable at http://cr.openjdk.java.net/~darcy/8067099.0/)
> On 2014-12-10 02:59, joe darcy wrote:
>> The time approaches when the one remaining category of lint warning
>> still present in the jdk repo, deprecation, will be eliminated. In
>> anticipation of that happy day, please review this simple patch to
>> enable the warning in the build:
>> diff -r f7c11da0b048 make/common/SetupJavaCompilers.gmk
>> --- a/make/common/SetupJavaCompilers.gmk Thu Dec 04 15:21:09 2014
>> +++ b/make/common/SetupJavaCompilers.gmk Tue Dec 09 17:30:32 2014
>> @@ -32,7 +32,7 @@
>> # To build with all warnings enabled, do the following:
>> # make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
>> -JAVAC_WARNINGS := -Xlint:all,-deprecation -Werror
>> +JAVAC_WARNINGS := -Xlint:all -Werror
>> # The BOOT_JAVAC setup uses the boot jdk compiler to compile the tools
>> # and the interim javac, to be run by the boot jdk.
>> As usual for this kind of change, a jprt job will be used to verify
>> the fix is valid on all platforms, etc.
More information about the build-dev