RFR: JDK-8068902: Solaris build fails with new 10u10 devkit

Tim Bell tim.bell at oracle.com
Wed Jan 14 23:15:20 UTC 2015

Hello Erik:

> Please review this small patch, which moves the SYSROOT_CFLAGS and 
> SYSROOT_LDFLAGS to the back of the compiler and linker command lines. 
> On linux, this shouldn't matter as we don't need to override the 
> --sysroot option. On Solaris, such an option does not exist, but 
> instead we set an explicit -I flag pointing to the system include 
> directory. This -I flag must be added after all other -I flags on the 
> command line, as otherwise, system headers would override application 
> headers, instead of the other way around. The same goes for -L flags 
> when linking.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8068902
> Webrev: http://cr.openjdk.java.net/~erikj/8068902/webrev.root.01/

Looks good to me.


More information about the build-dev mailing list