RFR: JDK-8071329: Stop exporting INCLUDE and LIB when building on windows
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Fri Jan 23 12:04:06 UTC 2015
On 2015-01-22 15:40, Erik Joelsson wrote:
> The new LDFLAGS requires unpack200.exe to stop being linked
> differently to all other executables. There is no reason for this
> discrepancy that I can find, it just seems like someone did a bit of a
> quick hack getting it to build long ago in the old build, and we
> wanted to keep it equivalent in build-infra.
I like the cleanup. Nevertheless, it would be good to check this by the
group owning unpack200. Is it core libs?
> The hotspot build still requires the variables to be exported, so they
> are still being defined in hotspot-spec.gmk.
> While working on this, I stumbled on a problem when running "make
> reconfigure". The PATH variable value, since exported in make, would
> get longer and longer for each time you run reconfigure. I fixed this
> by saving the original path and resetting it before running configure
> from make.
Apart from wanting a second opinion on the unpack200 stuff, it looks
good to me. Nice work!
More information about the build-dev