RFR: 8087156: SetupNativeCompilation ignores CFLAGS_release for cpp files
omajid at redhat.com
Fri Jun 12 16:08:08 UTC 2015
* Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> [2015-06-12 09:02]:
> Looks good to me too.
Thanks for the review! Sorry I was unable to credit you since I already
pushed the patch.
> However, this is not the first time we've encountered a problem like this. I
> ran into a similar problem some time ago. It's a very brittle system we
> have. I believe we should get rid of the CXXFLAGS and just have CFLAGS and
> let them cover c++ compilation as well.
> Do we have use cases where C and C++ both are used in the same library, and
> requires different flags?
I took a cursory look through everything (except hotspot makefiles) and
I don't see any obvious such case. All code uses either identical CFLAGS
and CXXFLAGS or only one of CFLAGS or CXXFLAGS.
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the build-dev