RFR: JDK-8087328: Move debuglevel info in version string from PRE to OPT
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Thu Jun 25 22:46:19 UTC 2015
On 2015-06-25 15:25, Erik Joelsson wrote:
> Please review this change to the new build number implementation in
> project Verona. This change is intended to go into the verona forest
> for now until it's time for integration into jdk9.
> In Magnus' original version string implementation, the debuglevel
> information is encoded into the PRE string. According to the latest
> status of JEP-223, it should rather be a part of the OPT string. In
> this patch, I have made that move.
> This means that the (relevant) configure options have changed from:
> I also had to introduce some way of telling the OPT_BASE string apart
> from the OPT_DEBUGLEVEL string when parsing a full version string. In
> the PRE string, the separator was a '.' but since that character is a
> valid part of the OPT string, something else is needed. I went with
> underscore '_' for now.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8087328
> Webrev: http://cr.openjdk.java.net/~erikj/8087328/webrev.01/
Looks good to me.
Note that this solution will require an update to the JEP-223 spec, to
allow underscore (_) to be an allowed character in the OPT string.
(Since, from the spec's point, both OPT_BASE and OPT_DEBUGLEVEL are
arbitrary divisions of the formal OPT string.)
More information about the build-dev