RFR: 8079345: After 8079248 fixed JDK still fails with "jdk\\bin\\management_ext.dll: The specified procedure could not be found"
staffan.larsen at oracle.com
Wed May 6 11:29:13 UTC 2015
> On 6 maj 2015, at 11:46, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
> On 2015-05-06 11:39, Erik Joelsson wrote:
>> This one looks better. Sorry for not spotting the problem in the previous review.
>> On 2015-05-06 11:24, Staffan Larsen wrote:
>>> My fix for 8079248 was broken, so here is a new attempt. I intend to push this directly to jdk9/hs since that is where 8079248 was pushed.
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8079345#comment-13638237
>>> webrev: http://cr.openjdk.java.net/~sla/8079345/webrev.00 <http://cr.openjdk.java.net/~sla/8079345/webrev.00>
> Looks good to me. If you care, maybe you could move (and properly indent) the comment about the flag to inside the "if windows" clause? You don't need to respin the webrev if you do that.
diff --git a/make/lib/Lib-jdk.management.gmk b/make/lib/Lib-jdk.management.gmk
@@ -39,10 +39,12 @@
-# In (at least) VS2013 and later, -DPSAPI_VERSION=1 is needed to generate
-# a binary that is compatible with windows versions older than 7/2008R2.
-# See MSDN documentation for GetProcessMemoryInfo for more information.
-BUILD_LIBMANAGEMENT_EXT_CFLAGS += -DPSAPI_VERSION=1
+ifeq ($(OPENJDK_TARGET_OS), windows)
+ # In (at least) VS2013 and later, -DPSAPI_VERSION=1 is needed to generate
+ # a binary that is compatible with windows versions older than 7/2008R2.
+ # See MSDN documentation for GetProcessMemoryInfo for more information.
+ LIBMANAGEMENT_EXT_CFLAGS += -DPSAPI_VERSION=1
LIBMANAGEMENT_EXT_OPTIMIZATION := HIGH
ifneq ($(findstring $(OPENJDK_TARGET_OS), solaris linux), )
More information about the build-dev