RFR: JDK-8153969: Clean up module src dir logic

Erik Joelsson erik.joelsson at oracle.com
Tue Apr 12 12:37:22 UTC 2016

New webrev with some more cleanup in CompileJavaModules.gmk. Fixed the 
variable name and also realized that the call to MakeDir was no longer 
necessary. Starting to look pretty neat.



On 2016-04-12 11:37, Erik Joelsson wrote:
> That is a good point, I will clean up that naming too.
> /Erik
> On 2016-04-11 18:26, Jonathan Gibbons wrote:
>> On 04/11/2016 05:28 AM, Erik Joelsson wrote:
>>> We currently have 3 places in the makefiles where the full list of 
>>> source dirs for each module is calculated. I have refactored this 
>>> into macros in make/common/Modules.gmk so that it's handled 
>>> uniformly. This will also make it simpler for other potential users 
>>> of this data, like IDE project generation.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153969
>>> Webrev: http://cr.openjdk.java.net/~erikj/8153969/webrev.top.01/
>>> /Erik
>> In a world where we are trying to differentiate betwen module paths 
>> and class paths, the name MODULECLASSPATH seems somewhat schizophrenic.
>> -- Jon

More information about the build-dev mailing list