RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86
erik.joelsson at oracle.com
Fri Apr 15 07:43:52 UTC 2016
Looks good to me.
On 2016-04-14 18:41, Mikael Vidstedt wrote:
> Please review the following change which removes the "client" VM from
> the default JIB build profile on windows-x86 and linux-x86:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8154209
> Webrev (top):
> Webrev (hotspot):
> When not including the client VM, the build system automatically
> creates a jvm.cfg which makes -client an alias for -server. At some
> point in the future we may choose to output a warning and/or refuse to
> start up if -client is specified, but at least for now silently
> falling back on the -server VM seems appropriate.
> The test/runtime/SharedArchiveFile/DefaultUseWithClient.java test
> assumes that CDS is always compiled in and enabled in the -client VM
> on windows-x86. Since -client will fall back on -server that is no
> longer true, so the test needs to be updated. I added an @ignore and
> filed the following issue to track fixing the test:
> In addition to a standard JPRT push job, Christian Tornqvist helped me
> run the runtime nightly tests and apart from the above mentioned test
> all tests were successful.
More information about the build-dev