RFR  8044773: Refactor jdk.net API so that it can be moved out of the base module
chris.hegarty at oracle.com
Tue Apr 26 09:16:34 UTC 2016
On 26 Apr 2016, at 09:20, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 25/04/2016 22:01, Chris Hegarty wrote:
>> One of the remaining open issues in JEP 200  is that the base module
>> exports the jdk.net package, thereby violating Principle 4 of JEP 200:
>> a Java SE module must not export any non-SE API packages without
> I took a first pass over this and it looks very good.
Webrev updated in-place:
> For the package name then sun.net.extnet repeats "net" and maybe sun.net.ext would be better.
> For the BaseExtendedSocketOptions then I think the FileDescriptor parameter should be the first parameter as that is the file descriptor to the socket that the methods operate on.
Agreed. Done. I had it this way at one point, but I don’t remember why
I changed it.
> In ExtendedSocketOptions then I assume the toString is not needed in checkValueType.
> There are "TODOs" in the tests and I assume it would be better to drop those and instead create an issue in JIRA to be addressed once jtreg is promoted with support for -limitmods.
Yes, this is better.
> There is also a TODO in Sockets.java "check this is working ok" that I assume needs attention before this is pushed.
Removed. Sorry, I thought I had removed this after I verified it was indeed
More information about the build-dev