RFR: JDK-8170784: JDK-8170651 broke cross compilation
erik.joelsson at oracle.com
Tue Dec 6 10:12:05 UTC 2016
When cross compiling arm, we use EXTRA_CFLAGS for the arm configuration
specific flags. That variable is used explicitly in
hotspot/make/lib/CompileLibjsig.gmk. When compiling for the build
platform, we don't want the contents of that variable.
I agree on the testing part.
On 2016-12-06 10:59, David Holmes wrote:
> Thanks Erik. Looks good.
> I suspected it might be that part but couldn't quite connect the dots.
> And I have to express my concern that those changes were not
> adequately tested!
> On 6/12/2016 6:52 PM, Erik Joelsson wrote:
>> When cleaning up legacy hotspot settings in JDK-8170651, a bit too much
>> was removed. Now we can't cross compile certain arm platforms.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170784
>> diff -r 9475c1488d29 common/autoconf/buildjdk-spec.gmk.in
>> --- a/common/autoconf/buildjdk-spec.gmk.in
>> +++ b/common/autoconf/buildjdk-spec.gmk.in
>> @@ -89,4 +89,10 @@
>> # Control wether Hotspot builds gtest tests
>> BUILD_GTEST := false
>> JVM_VARIANTS := server
>> +# Some users still set EXTRA_*FLAGS on the make command line. Must
>> +# make sure to override that when building buildjdk.
>> +override EXTRA_CFLAGS :=
>> +override EXTRA_CXXFLAGS :=
>> +override EXTRA_LDFLAGS :=
More information about the build-dev