RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12
thomas.stuefe at gmail.com
Sun Dec 18 08:23:16 UTC 2016
thanks for your review, your suggestion makes sense. Will incorporate it
into the next webrev; but first I have to try and meet Volkers linker
On Thu, Dec 15, 2016 at 11:33 AM, David Holmes <david.holmes at oracle.com>
> Hi Thomas,
> On 15/12/2016 4:43 PM, Thomas Stüfe wrote:
>> Hi all,
>> please review this small change. It fixes the gtest build on AIX and
>> enables it by default.
>> Note that even though this is a fix for AIX, a cast needed to be added to
>> shared test coding. This is because xlC struggles with certain template
>> expansions and I had to help it by providing an explicit cast.
> These kind of problems have been reported in the past. The way we chose to
> address them was to convert to use ASSERT_TRUE(i == NULL) rather than apply
> casts to make the ASSERT_EQ(i, NULL) compile.
> Because linker options were changed as well, this unfortunately this
>> spreads over two forest parts, so two webrevs were needed.
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8171225
>> (top level)
>> Note that the toplevel change contains the newly generated configure.sh. I
>> was not sure if that was needed, but it is included for convenience.
>> Kind Regards, Thomas
More information about the build-dev