RFR: 8149594 - Clean up Hotspot makefiles

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Wed Feb 10 22:10:51 UTC 2016

Sending again to include the build-dev list.

Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson:
> Hi,
> Please review this cleanup of the Hotspot makefiles.
> Since I have been spending some time in the makefiles lately there were a few
> random cleanups that I couldn't stop myself from doing. Most of these are made
> to make the linux and bsd makefiles more alike. This has helped a lot when
> porting the framework to the different platforms.
> There are a couple of preparing alignment changes that I included in this
> cleanup to make the Google test patch easier to review later.
> There are also a couple of "real" changes:
> * In make/bsd/makefiles/buildtree.make we set up OS_VENDOR with the motivation
> that we don't include defs.make. Three lines below we include defs.make.
> * In make/bsd/makefiles/buildtree.make the 'install' target depends on
> 'install_jsigs'. There is no rule called 'install_jsigs', it is called
> 'install_jsig'.
> Another difference that I find interesting but that I have not changed in this
> patch (I can do that if requested) is that in the bsd version of fastdebug.make
> VERSION is set to "fastdebug" but in the linux version it is set to "optimized".
> Given the name of the makefile fastdebug seems more correct, but whichever is
> the correct value, shouldn't they be the same on linux and bsd?
> https://bugs.openjdk.java.net/browse/JDK-8149594
> http://cr.openjdk.java.net/~jwilhelm/8149594/webrev.00/
> Thanks,
> /Jesper

More information about the build-dev mailing list