RFR: JDK-8149647 Incremental enhancements from build-infra
erik.joelsson at oracle.com
Mon Feb 15 09:00:54 UTC 2016
On 2016-02-12 11:11, Magnus Ihse Bursie wrote:
> On 2016-02-11 14:26, Erik Joelsson wrote:
>> flags.m4: spelling "contitionally"
>> Otherwise it looks good enough to me provided that it builds and
>> output is still the same.
> I ran it through JPRT with your new and improved compare script. I got
> a compare failure on macosx for libosxui.dylib. I re-ran the test and
> it passed (!). I ran a separate test with an empty patch file on
> macosx, and it too failed on libosxui. Most libraries, but not
> libosxui.dylib are listed in the ACCEPTED_BIN_DIFF section. So I took
> the liberty of adding libosxui.dylib to that section as well, as part
> of the patch. Hope you don't mind. :)
The intermittent differences are hard to catch and will require
continuous maintenance of the script. The lib in question is newer than
compare.sh IIRC. Thanks for fixing it!
>> On 2016-02-11 12:20, Magnus Ihse Bursie wrote:
>>> Here is another batch of small fixes and enhancements from the
>>> build-infra project forest.
>>> * Compiler version framework:
>>> - Create a TOOLCHAIN_CHECK_COMPILER_VERSION macro
>>> - Test for minimum versions for certain compilers in configure
>>> * Start supporting mapfiles on all platforms (windows and macosx as
>>> * Fix errors/bad looking output in configure
>>> * Fix bugs for debug symbols on macosx when building with
>>> * Simplify hotspot version.rc: replace HS_VER with JDK_VER, and
>>> HS_DOTVER with JDK_DOTVER (they are always the same)
>>> * INCLUDE_SA fixes:
>>> - Move the check of INCLUDE_SA to jdk-options.m4.
>>> - Use INCLUDE_SA for proper testing for SA in makefiles.
>>> * Set --with-native-debug-symbols default to "none" for STATIC_BUILD.
>>> * Compare script improvements
>>> * Incremental fixes in NativeCompilation.gmk.
>>> * Incremental fixes in flags.m4
>>> * Remove left-over comments
>>> * Misc other changes
>>> * Whitespace fixes
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8149647
More information about the build-dev