RFR(S): 8146638: Only use compiler option files if they are really supported by the toolchain

Erik Joelsson erik.joelsson at oracle.com
Fri Jan 8 08:38:46 UTC 2016

Change looks good to me. I will sponsor it.


On 2016-01-07 20:00, Volker Simonis wrote:
> Hi,
> can somebody please review and sponsor (needs regeneration of
> generated-configure.sh because of closed sources) the following small
> fix:
> http://cr.openjdk.java.net/~simonis/webrevs/2016/8146638/
> https://bugs.openjdk.java.net/browse/JDK-8146638
> Older versions of gcc don't support the '@file' syntax for passing
> options to the compiler trough an options file.
> So better check during the configuration phase if gcc supports the
> '@file' syntax and configure the make appropriately.
> Inside NativeCompilation.gmk we now only use compiler option files if
> COMPILER_COMMAND_FILE_FLAG was defined during the configure process
> (instead of explicitly checking for the sstudio toolchain which
> doesn't support compiler option files as well).
> Tested with old/new GCC which don't/support @file and on Solaris to
> verify the nothing has been broken.
> Thank you and best regards,
> Volker

More information about the build-dev mailing list