RFR (L) JEP 280: Indify String Concatenation (integration)
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed Jan 27 14:07:46 UTC 2016
On 2016-01-27 14:55, Aleksey Shipilev wrote:
> Hi again,
> This is a formal pre-integration review thread for JEP 280 ("Indify
> String Concatenation") integration:
> The JEP is Targeted, the CCC is approved, the code reviews and
> pre-integration checks are clean.
> Code changes are happening simultaneously in four components:
> a) (M) javac changes that emit indy:
> b) (L) JDK changes with StringConcatFactory and friends, plus fixing
> the regression tests that do not expect additional indys:
> c) (XS) Build changes that force emitting the "legacy" inline
> StringBuilder concat in a few cases (e.g. when pre-JDK 9 bytecode is
Build changes look good to me.
Just out of curiosity, what does "indy" mean in this context? I have not
heard this expression and googling fails to bring up anything relevant.
> d) (XS) HotSpot changes that fix a GC regression test that now
> allocates some metaspace from within the test methods having a string
> These changes were already reviewed by multiple people, and so I would
> like to keep the comments only for serious breaking issues at this
> point. (Note that this thread cross-posts over several mailing lists:
> bike-shedding discussion would get multiplied a lot!)
> Formal acknowledgements from Reviewers would be appreciated. Pending no
> show-stopper comments, I'd like to push this through jdk9/dev in 24 hours.
More information about the build-dev