RFR: JDK-8157511: JDK-8157348 broke gensrc of module infos with extra provides

Mandy Chung mandy.chung at oracle.com
Sat May 21 18:32:55 UTC 2016


> On May 21, 2016, at 11:06 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> Another fallout from JDK-8157511. We don't just modify exports, but also provides and those do not deal with packages, so the new condition disables all of them. This fix makes the handling of exports and provides very explicit. That's probably a good thing since we only support exports and provides in the module-info.extra files. I have verified on a mac that the missing AppleProvider is now present.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8157511
> Webrev: http://cr.openjdk.java.net/~erikj/8157511/webrev.top.01/

Looks okay.

I think we need to re-examine the fix for JDK-8157348.  Filtering exports and provides listed in module-info.java.extra does not seem quite right and I'd like to look at the configuration having this issue and see if there is other way resolving it.  


More information about the build-dev mailing list