RFR: JDK-8191439: Race in building jdk.rmic.interim

Tim Bell tim.bell at oracle.com
Tue Dec 5 01:14:24 UTC 2017


Looks good to me as well.


On 12/04/17 15:54, mandy chung wrote:
> Looks good to me.
> Mandy
> On 12/4/17 3:48 PM, Erik Joelsson wrote:
>> We have a race when building jdk.rmic.interim. This is caused by
>> CompileInterimLangtools.gmk and CompileInterimRmic.gmk using the same
>> modular output directory ($(BUILDTOOLS_OUTPUTDIR)/interim_modules),
>> and then makefiles running javac from interim langtools at the same
>> time as CompileInterimRmic is running. This patch splits the output
>> directories. That way, tools running javac will not see any new files
>> created by CompileInterimRmic ever.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191439
>> Webrev: http://cr.openjdk.java.net/~erikj/8191439/webrev.01/
>> /Erik

More information about the build-dev mailing list