RFR(XXXS): 8193407: jdk/hs fails Solaris slowdebug test-image build
Daniel D. Daugherty
daniel.daugherty at oracle.com
Wed Dec 13 02:24:46 UTC 2017
Thanks for the review!
On 12/12/17 9:24 PM, Vladimir Kozlov wrote:
> Reviewed. Looks good.
> On 12/12/17 6:16 PM, David Holmes wrote:
>> Hi Dan,
>> On 13/12/2017 12:13 PM, Daniel D. Daugherty wrote:
>>> I have a 1-liner fix to solve a Solaris slowdebug test-image build
>>> JDK-8193407 jdk/hs fails Solaris slowdebug test-image build
>>> Here is the context diff:
>>> $ hg diff
>>> diff -r a576e1b6784d make/test/JtregNativeHotspot.gmk
>>> --- a/make/test/JtregNativeHotspot.gmk Tue Dec 12 14:14:06 2017
>>> +++ b/make/test/JtregNativeHotspot.gmk Tue Dec 12 21:07:03 2017
>>> @@ -113,6 +113,7 @@
>>> BUILD_HOTSPOT_JTREG_LIBRARIES_LIBS_libHandshakeTransitionTest := -lc
>>> BUILD_HOTSPOT_JTREG_LIBRARIES_LIBS_libHasNoEntryPoint := -lc
>>> BUILD_HOTSPOT_JTREG_LIBRARIES_LIBS_libReturnError := -lc
>>> + BUILD_HOTSPOT_JTREG_LIBRARIES_LIBS_libCNLookUp := -lc
>>> ifeq ($(OPENJDK_TARGET_OS), linux)
>>> David Holmes suggested the possible fix and I have tested the fix with
>>> Solaris X64 'release', 'fastdebug' and 'slowdebug' builds.
>> Thanks for that!
>>> David is the first (R)eviewer. Since this affects a Compiler team
>>> test, it would be good to hear from someone on the Compiler team.
>>> Since it is a Makefile change, it would be good to hear from someone
>>> on the build-dev at ... alias...
>> I think that is a bit of overkill. I was going to say push this under
>> trivial rules!
>> Aside: I've started a separate email thread on why we need to list
>> -lc explicitly in the makefile.
>>> Thanks, in advance, for questions, comments, or suggestions.
More information about the build-dev