RFR: 8192837 Need new test for release file info

David Holmes david.holmes at oracle.com
Tue Dec 19 02:32:32 UTC 2017


Hi Randy,

jdk/sanity/Test8192837.java

We don't name tests with bug numbers any more - the file/class should be 
renamed to something appropriate to its actual function.

   64                 // grab the line
   65                 if (readIn.startsWith("SOURCE="))
   66                     fishForSOURCE = readIn;

Do you expect to find more than one SOURCE line? If not this should 
"break". If so, then you're only going to check the last one found.

   98         if (runtime.contains("OpenJDK"))
   99             new Test8192837(jdkPath + "/release");
  100         else
  101             System.out.println("Not an OpenJDK.");

It would be preferable if this can be done via some @requires tag rather 
than within the test. But otherwise it would be better to print "Test 
skipped: not an OpenJDK build".

Thanks,
David

On 19/12/2017 3:23 AM, Erik Joelsson wrote:
> Redirecting to correct list.
> 
> The test seems to do what it set out to do.
> 
> /Erik
> 
> 
> On 2017-12-18 17:55, Randy Crihfield wrote:
>> I have created an OpenJDK negative test that confirms the closed 
>> source files are not included in the SOURCE.
>>
>> Version of the actual test for review:
>>
>> http://cr.openjdk.java.net/~shurailine/8192837/webrev.00/
>>
>> Any comments/suggestions are welcome, also I will need a sponsor for 
>> it at the end…
>>
>> Randy
>>
> 


More information about the build-dev mailing list