RFR:8170868: DefaultProxySelector should use system defaults on Windows, MacOS and Gnome

Chris Hegarty chris.hegarty at oracle.com
Wed Feb 1 13:27:10 UTC 2017

> On 1 Feb 2017, at 12:35, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> Hello,
> In NetworkingLibraries.gmk, the explicit exclusion of $(JDK_TOPDIR)/src/java.base/unix/native/libnet/DefaultProxySelector.c shouldn't be necessary. SetupNativeCompilation should pick the first found source file of the same name (or rather, that would end up as the same object) and the macro FindSrcDirsForLib should guarantee that the most specific file is found first. 

I can confirm that this works fine. Thanks Erik.


> /Erik
> On 2017-02-01 13:00, Chris Hegarty wrote:
>> Can someone from the build group please give the build part of
>> this the once over.
>> Thanks,
>> -Chris.
>>> On 31 Jan 2017, at 19:14, Zeller, Arno <arno.zeller at sap.com> wrote:
>>> Hi Chris,
>>> thanks for all the improvements. I imported your webrev and prepared another webrev:
>>> http://cr.openjdk.java.net/~clanger/webrevs/8170868.6/
>>> I have seen the multiple DIRECTs myself during testing and I think filtering on the java side is a very elegant solution.
>>> Thanks for this!

More information about the build-dev mailing list