RFR: JDK-8174895: test/TestCommon.gmk: value of JTREG_TESTVM_MEMORY_OPTION is missing1/2acghpy

Erik Joelsson erik.joelsson at oracle.com
Tue Feb 14 08:42:07 UTC 2017

There is a small bug in the new test/TestCommon.gmk that prevents the 
JTREG_TESTVM_MEMORY_OPTION from propagating to the jtreg command line. 
The fix is to append to JTREG_TEST_OPTIONS instead of overwriting the 
current value further down in the file. Patch provided by Amy Lu.

Bug: https://bugs.openjdk.java.net/browse/JDK-8174895


diff -r 4eb77fb98952 test/TestCommon.gmk
--- a/test/TestCommon.gmk
+++ b/test/TestCommon.gmk
@@ -370,7 +370,7 @@
  # Give tests access to JT_JAVA, see JDK-8141609
  # Set other vm and test options
-JTREG_TEST_OPTIONS = $(JAVA_ARGS:%=-javaoptions:%) 
$(JAVA_OPTIONS:%=-vmoption:%) $(JAVA_VM_ARGS:%=-vmoption:%)
+JTREG_TEST_OPTIONS += $(JAVA_ARGS:%=-javaoptions:%) 
$(JAVA_OPTIONS:%=-vmoption:%) $(JAVA_VM_ARGS:%=-vmoption:%)

  ifeq ($(IGNORE_MARKED_TESTS), true)
    # Option to tell jtreg to not run tests marked with "ignore"


More information about the build-dev mailing list