RFR: JDK-8176172: Imported FX modules have have residual_imported.marker file

Erik Joelsson erik.joelsson at oracle.com
Tue Mar 7 08:51:52 UTC 2017


The jmods for the imported javafx modules end up with _imported.marker 
files in them. The root cause of this issue is that we don't have a 
coherent naming scheme for our touch/marker files in the build. I have 
filed JDK-8176264 to address this properly. For the immediate problem I 
instead propose this simple patch to the jmod creation. I have verified 
that the jmods no longer contain any touch files from the build.

Bug: https://bugs.openjdk.java.net/browse/JDK-8176172


diff -r 4d29ee32d926 make/CreateJmods.gmk
--- a/make/CreateJmods.gmk
+++ b/make/CreateJmods.gmk
@@ -139,7 +139,7 @@
              --os-arch $(OPENJDK_TARGET_CPU_LEGACY) \
              --os-version $(REQUIRED_OS_VERSION) \
              --module-path $(JMODS_DIR) \
-        --exclude 
'**{_the.*,*.diz,*.debuginfo,*.dSYM/**,*.dSYM,*.pdb,*.map}' \
+        --exclude 
'**{_the.*,_*.marker,*.diz,*.debuginfo,*.dSYM/**,*.dSYM,*.pdb,*.map}' \
          $(JMOD_FLAGS) $(JMODS_TEMPDIR)/$(notdir $@)
      $(MV) $(JMODS_TEMPDIR)/$(notdir $@) $@


More information about the build-dev mailing list