RFR: JDK-8172312 Update docs target and image for new combined docs
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Fri Mar 31 11:49:50 UTC 2017
On 2017-03-31 10:02, Erik Joelsson wrote:
> Looks good to me.
> My suggestion was to to add the rmic dirs to those variables in
> Javadoc.gmk, but your solution is even better. I didn't realize that
> you could just add to a "pathlist" with another call to PathList, so I
> thought we had to get at the variables that GetModuleSrcPath uses as
That's even documented! :-) "Safe for multiple nested calls."
> Anyway, very nice to not have to duplicate the list of source dirs
> On 2017-03-30 22:17, Magnus Ihse Bursie wrote:
>> On 2017-03-30 21:19, Magnus Ihse Bursie wrote:
>>> New webrev coming up soon...
>> Here it is:
>> Changes since last webrev:
>> * Removed java.base from DOCS_MODULES and updated comment.
>> * Removed jdk.crypto.mscapi and jdk.crypto.ucrypto from DOCS_MODULES.
>> * Replaced JAVADOC_SOURCE_DIRS with
>> JAVADOC_SOURCE_PATH := $(call PathList, $(call GetModuleSrcPath) \
>> $(SUPPORT_OUTPUTDIR)/rmic/* $(JDK_TOPDIR)/src/*/share/doc/stub)
>> and added it to JAVADOC_VARDEPS
>> * Fixed JAVADOC_TOP indentation
>> * Removed java.base from list of modules for reference javase javadoc
>> * Updated REFERENCE_TARGET_DIR to $(IMAGES_OUTPUTDIR)/javase-docs/api
More information about the build-dev