RFR: JDK-8189430: make/hotspot/copy/Copy-java.base.gmk in wrong location after consolidation

David Holmes david.holmes at oracle.com
Tue Oct 17 12:39:07 UTC 2017

Hi Erik,

Seems reasonable. Though does highlight we still need to close out 8167078.


On 17/10/2017 10:32 PM, Erik Joelsson wrote:
> In the consolidation restructuring, I missed merging the contents of 
> make/hotspot/copy/Copy-java.base.gmk with make/copy/Copy-java.base.gmk. 
> The only relevant part that needs to be preserved is the optional 
> copying of libffi.so.? which we need when building zero internally at 
> Oracle. The rest of the contents of this file is just copy rules for 
> header files that are currently disabled. These header files are 
> currently being copied from the old jdk repository instead of the old 
> hotspot repository. Keeping these unused rules around serves no point.
> This patch moves the libffi copying to the correct place and discards 
> the rest of the forgotten file.
> Webrev: http://cr.openjdk.java.net/~erikj/8189430/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189430
> /Erik

More information about the build-dev mailing list