RFR: JDK-8189607 Remove duplicated jvmticmlr.h
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed Oct 18 08:37:18 UTC 2017
On 2017-10-18 10:26, Erik Joelsson wrote:
> On 2017-10-18 10:04, Magnus Ihse Bursie wrote:
>> The file jvmticmlr.h is stored twice in the repo, both in hotspot and
>> in java.base. They are both identical, and only the java.base version
>> is included in the final product. This might arguably have been
>> useful in a pre-consolidated world, but makes absolutely no sense now.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8189607
> The question is, which file location makes the most sense. I think
> your pick of java.base/share/native/include probably makes more sense
> as that makes it much clearer that this is an exported header file.
Yes, that was my reasoning. Also, the file is not really tied to hotspot
per se -- if you were to plug in another VM, you'd still need this file.
Combined with the fact that this was the file that was exported to the
world. (Which doesn't *really* make any difference in this case, since
the files were identical...)
> Looks good to me.
More information about the build-dev