RFR: JDK-8189607 Remove duplicated jvmticmlr.h

mandy chung mandy.chung at oracle.com
Wed Oct 18 17:57:26 UTC 2017

On 10/18/17 1:26 AM, Erik Joelsson wrote:
> On 2017-10-18 10:04, Magnus Ihse Bursie wrote:
>> The file jvmticmlr.h is stored twice in the repo, both in hotspot and 
>> in java.base. They are both identical, and only the java.base version 
>> is included in the final product. This might arguably have been 
>> useful in a pre-consolidated world, but makes absolutely no sense now.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8189607
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8189607-remove-duplicated-jvmticmlr/webrev.01
> The question is, which file location makes the most sense. I think 
> your pick of java.base/share/native/include probably makes more sense 
> as that makes it much clearer that this is an exported header file.

jvmticmlr.h is an exported header file and 
java.base/share/native/include is a proper location as described in JEP 
201 about the modular source layout.

The change looks good to me too.


More information about the build-dev mailing list