RFR (L, tedious again, sorry) 8189610: Reconcile jvm.h and all jvm_md.h between java.base and hotspot

mandy chung mandy.chung at oracle.com
Thu Oct 26 21:27:19 UTC 2017

On 10/26/17 1:34 PM, coleen.phillimore at oracle.com wrote:
> On 10/26/17 2:47 PM, mandy chung wrote:
>> On 10/26/17 2:57 AM, Magnus Ihse Bursie wrote:
>>> A third option is to remove the support for link-time-opt entirely, 
>>> if it's not really used.
>>> * src/java.base/unix/native/include/jvm_md.h and 
>>> src/java.base/windows/native/include/jvm_md.h:
>>> These files define a public API, and contain non-trivial changes. I 
>>> suspect you should file a CSR request. (Even though I realize you're 
>>> only matching the header file with the reality.)
>> jvm.h and jvm_md.h are not public API and they are not copied to the 
>> $JAVA_HOME/includes directly.  This does raise the question that 
>> jvm*.h may belong to other location than 
>> src/java.base/{share,$OS}/native/include.
> I'm not sure where else it would go honestly, but it could be moved 
> outside this changeset.  The good thing about where it is, is that the 
> -I directives in the makefiles find both jni.h and jvm.h.

I agree we should keep this location for this change (the location is a 
separate issue).  I reviewed the change that looks good to me.


More information about the build-dev mailing list