[11] RFR: 8189784: Parsing with Java 9 AKST timezone returns the SystemV variant of the timezone

Erik Joelsson erik.joelsson at oracle.com
Tue Apr 10 16:29:20 UTC 2018


This looks very good. Thanks!

(reviewed build part)

/Erik


On 2018-04-09 18:00, naoto.sato at oracle.com wrote:
> Thanks, Erik. Modified GensrcCLDR.gmk as suggested:
>
> http://cr.openjdk.java.net/~naoto/8189784/webrev.03/
>
> Naoto
>
> On 4/9/18 4:15 PM, Erik Joelsson wrote:
>> Hello Naoto,
>>
>> Looks good, just a style issue.
>>
>> When breaking a recipe line, please add 4 additional spaces (after 
>> the tab) for continuation indent [1]. In this case I would also 
>> advocate breaking the line sooner to make side by side comparisons 
>> easier in the future.
>>
>> /Erik
>>
>> [1] http://openjdk.java.net/groups/build/doc/code-conventions.html
>>
>> On 2018-04-09 13:20, Naoto Sato wrote:
>>> Hello,
>>>
>>> Please review the changes to the following issue:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8189784
>>>
>>> The proposed changeset is located at:
>>>
>>> http://cr.openjdk.java.net/~naoto/8189784/webrev.02/
>>>
>>> There were two causes of the issue. One was that j.t.f.ZoneName 
>>> contained hard coded mappings based on the old CLDR data and never 
>>> been updated. The other reason was that CLDR's deprecated zones 
>>> ("SystemV" ones, in this case) were not properly replaced.
>>>
>>> I am including build-dev for the review, as the change includes 
>>> generating ZoneName mapping at the build time from the template.
>>>
>>> Naoto
>>



More information about the build-dev mailing list