RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Apr 25 09:15:22 UTC 2018


On 2018-04-25 10:14, Baesken, Matthias wrote:
>
> Hi Erik, thanks !
>
> Can I consider this as a review ?
>
> In the meantime I created a webrev + bug :
>
> webrev for review  :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8202200/ 
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8202200/>
>
Looks good to me.

/Magnus
>
> bug :
>
> https://bugs.openjdk.java.net/browse/JDK-8202200
>
> Regards, Matthias
>
> *From:*Erik Joelsson [mailto:erik.joelsson at oracle.com]
> *Sent:* Montag, 23. April 2018 17:43
> *To:* Baesken, Matthias <matthias.baesken at sap.com>; 
> 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>
> *Cc:* serviceability-dev at openjdk.java.net; Schmidt, Lutz 
> <lutz.schmidt at sap.com>
> *Subject:* Re: INCLUDE_SA/serviceability agent - support on s390x
>
> Makes sense to me. Looks good.
>
> /Erik
>
> On 2018-04-23 05:01, Baesken, Matthias wrote:
>
>     Hello,   as far as I know  the serviceability agent   is not 
>     supported on linux s390x .
>
>     However  (unlike  on aix where it is not supported as well) ,
>      INCLUDE_SA=false    is not set  in the central configure  m4 files .
>
>     Should we set it  ( suggested diff below)  ?
>
>     Best regards, Matthias
>
>     hg diff
>
>     diff -r fcd5df7aa235 make/autoconf/jdk-options.m4
>
>     --- a/make/autoconf/jdk-options.m4      Wed Apr 18 11:19:32 2018 +0200
>
>     +++ b/make/autoconf/jdk-options.m4      Mon Apr 23 13:46:17 2018 +0200
>
>     @@ -238,6 +238,9 @@
>
>        if test "x$OPENJDK_TARGET_OS" = xaix ; then
>
>     INCLUDE_SA=false
>
>        fi
>
>     +  if test "x$OPENJDK_TARGET_CPU" = xs390x ; then
>
>     + INCLUDE_SA=false
>
>     +  fi
>
>     AC_SUBST(INCLUDE_SA)
>
>     # Compress jars
>
>     Best regards, Matthias
>



More information about the build-dev mailing list