[8u] RFR: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

Kevin Walls kevin.walls at oracle.com
Thu Apr 26 08:38:09 UTC 2018


Thanks Erik -

I went ahead with the jdk's make/CopyFiles.gmk change, and added 
SetupCopyFiles to the base repo's make/common/MakeBase.gmk.

I updated the webrev, to include base and jdk repos:

http://cr.openjdk.java.net/~kevinw/8042707/webrev.01/

I'm getting these build OK with VS2012, but there will be further 
hotspot change at least for VS2013 to be a working option in 8u.

Thanks
Kevin
(my previous reply was not the the list, so this is the open response!)



On 20/04/2018 23:27, Erik Joelsson wrote:
> The root repo changes look ok.
>
> The changes in Copy-java.base.gmk applies to jdk/make/CopyFiles.gmk. 
> Those changes are definitely needed.
>
> /Erik
>
>
> On 2018-04-20 13:18, Kevin Walls wrote:
>> Hi,
>>
>> I'd like to request a review of the backport from 9 to 8u:
>>
>> 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 
>> (VS2013)
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8042707
>>
>> 9 changesets:
>> base repo: http://hg.openjdk.java.net/jdk9/jdk9/rev/39ee0ee4f890
>> jdk repo: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/c622a8ba90ad
>>
>> 9 review thread: 
>> http://mail.openjdk.java.net/pipermail/build-dev/2015-January/014029.html
>>
>>
>> Notes:
>> base repo:
>> toolchain_windows.m4: quite a bit of manual work, but no conflicts.
>> make/common/MakeBase.gmk: changes in SetupCopyFiles which we don't 
>> have in 8u
>> flags.m4: we don't call it COMMON_CXXFLAGS_JDK in 8u, but made the 
>> same change.
>>
>> jdk repo:
>> make/copy/Copy-java.base.gmk we don't have in 8u. The other two files 
>> apply cleanly.
>>
>>
>> Clearly this backport isn't to change anything about what compilers 
>> are supported or recommended,
>> it's just about the build infrastructure.
>>
>>
>> 8u change: webrev of the base repo changes:
>> http://cr.openjdk.java.net/~kevinw/8042707/webrev.00/
>>
>> Many thanks
>> Kevin
>>
>



More information about the build-dev mailing list