RFR(xs): 8202325: [aix] disable warnings-as-errors by default

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Apr 26 17:26:59 UTC 2018


Sounds reasonable. 

The code look good but the comment "Do not change default value." seems to be more of a comment on the removed code, so I think it just looks confusing without adding anything of real value in the resulting code. Maybe rephrase "default is already set" or so, or just delete?

/Magnus

> 26 apr. 2018 kl. 16:03 skrev Thomas Stüfe <thomas.stuefe at gmail.com>:
> 
> Hi all,
> 
> may I have reviews please:
> 
> https://bugs.openjdk.java.net/browse/JDK-8202325
> http://cr.openjdk.java.net/~stuefe/webrevs/8202325-aix-disable-warnings-as-errors/webrev.00/webrev/
> 
> We decided to disable warnings as errors by default on AIX. This is a
> pragmatic decision - we will never be able to fix all the many xlC
> warnings and the build since long only worked when disabling
> warnings-as-errors.
> 
> So, might as well make this the default.
> 
> Best regards, Thomas



More information about the build-dev mailing list