RFR(xs): 8202325: [aix] disable warnings-as-errors by default
thomas.stuefe at gmail.com
Thu Apr 26 18:51:36 UTC 2018
I think I'll just delete the comment. Thanks for the review!
On Thu, Apr 26, 2018 at 7:26 PM, Magnus Ihse Bursie
<magnus.ihse.bursie at oracle.com> wrote:
> Sounds reasonable.
> The code look good but the comment "Do not change default value." seems to be more of a comment on the removed code, so I think it just looks confusing without adding anything of real value in the resulting code. Maybe rephrase "default is already set" or so, or just delete?
>> 26 apr. 2018 kl. 16:03 skrev Thomas Stüfe <thomas.stuefe at gmail.com>:
>> Hi all,
>> may I have reviews please:
>> We decided to disable warnings as errors by default on AIX. This is a
>> pragmatic decision - we will never be able to fix all the many xlC
>> warnings and the build since long only worked when disabling
>> So, might as well make this the default.
>> Best regards, Thomas
More information about the build-dev