RFR: JDK-8196524: Align MaxRAMPercentage settings between open and closed

Tim Bell tim.bell at oracle.com
Thu Feb 1 00:15:10 UTC 2018


Erik:

> An internal test at Oracle is failing because of a faulty shell
> expression in a makefile for calculating the value for MaxRAMPercentage.
> We already have such a calculation in TestCommon.gmk so we should just
> use that, but it needs to be exported in a separate variable to be able
> to do so.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8196524
>
> Webrev: http://cr.openjdk.java.net/~erikj/8196524/webrev.01/

test/TestCommon.gmk

You didn't change this line, however:

361 CONCURRENCY := $(shell awk \

Should it be $(AWK) instead of awk to be consistent with lines 254 ... 256?

Thanks, Erik.  Looks good otherwise.

/Tim




More information about the build-dev mailing list