[11] RFR JDK-8197865: @moduleGraph taglet generates incorrect link to module graph

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Feb 13 23:32:18 UTC 2018


+1

-- Jon

On 02/13/2018 11:47 AM, mandy chung wrote:
> Good. I see you pushed the fix to Docs.gmk.
>
> Kumar, Jon - can you please review this patch?
> diff --git a/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java b/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java
> --- a/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java
> +++ b/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java
> @@ -64,7 +64,7 @@
>           }
>   
>           String moduleName = ((ModuleElement) element).getQualifiedName().toString();
> -        String imageFile = moduleName + "/module-graph.png";
> +        String imageFile = "module-graph.png";
>           int thumbnailHeight = -1;
>           String hoverImage = "";
>           if (!moduleName.equals("java.base")) {
>
> Mandy



More information about the build-dev mailing list