RFR(S): 8196992: Resolve disabled warnings for libdt_socket
christoph.langer at sap.com
Fri Feb 23 08:48:46 UTC 2018
Looks good, Chris.
> -----Original Message-----
> From: build-dev [mailto:build-dev-bounces at openjdk.java.net] On Behalf Of
> Chris Plummer
> Sent: Freitag, 23. Februar 2018 02:04
> To: build-dev at openjdk.java.net build-dev <build-dev at openjdk.java.net>;
> serviceability-dev <serviceability-dev at openjdk.java.net>
> Subject: RFR(S): 8196992: Resolve disabled warnings for libdt_socket
> Please review the following:
> diff --git a/make/lib/Lib-jdk.jdwp.agent.gmk
> --- a/make/lib/Lib-jdk.jdwp.agent.gmk
> +++ b/make/lib/Lib-jdk.jdwp.agent.gmk
> @@ -43,7 +43,6 @@
> OPTIMIZATION := LOW, \
> CFLAGS := $(CFLAGS_JDKLIB) -DUSE_MMAP \
> $(LIBDT_SOCKET_CPPFLAGS), \
> - DISABLED_WARNINGS_gcc := shift-negative-value, \
> MAPFILE := $(TOPDIR)/make/mapfiles/libdt_socket/mapfile-vers, \
> LDFLAGS := $(LDFLAGS_JDKLIB) \
> $(call SET_SHARED_LIBRARY_ORIGIN), \
> This change is undoing the makefile change done as part of JDK-8196985.
> The only warning that was turning up in libdt_socket code before
> JDK-8196985 was done has already been fixed by JDK-8196909. Thus no
> warnings need to be fixed.
> After removing the above makefile code, I tested by building with the
> new toolchain. As a first test I undid the socketTransport.cpp fix from
> JDK-8196909 to verify that the new toolchain exposed the warning. Then I
> reverted socketTransport.cpp back to tip sources and saw no warnings
> with the new toolchain.
More information about the build-dev