RFR: JDK-8198627 JDK-8198318 broke readlink testing

Volker Simonis volker.simonis at gmail.com
Fri Feb 23 15:19:30 UTC 2018


Good patch, Magnus!

We've been affected by this as well but instead of digging deeper into
the problem we've installed "readlink" on our AIX build machines,
where it wasn't available until now. Good to know that "readlink" is
still not a mandatory requirement for the build :)


On Fri, Feb 23, 2018 at 2:24 PM, Magnus Ihse Bursie
<magnus.ihse.bursie at oracle.com> wrote:
> The if line introduced in JDK-8198318 is missing a "test".
> Thanks to Jon and Erik for discovering the problem and the solution.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8198627
> Patch inline:
>
> diff --git a/make/autoconf/basics.m4 b/make/autoconf/basics.m4
> --- a/make/autoconf/basics.m4
> +++ b/make/autoconf/basics.m4
> @@ -263,7 +263,7 @@
>        READLINK_TESTED=yes
>      fi
>
> -    if test "x$READLINK" != x && "x$READLINK_ISGNU" != x; then
> +    if test "x$READLINK" != x && test "x$READLINK_ISGNU" != x; then
>        $1=`$READLINK -f [$]$1`
>      else
>        # Save the current directory for restoring afterwards
>
> /Magnus


More information about the build-dev mailing list