RFR JDK-8197533 move javax.transaction.xa into its own module

joe darcy joe.darcy at oracle.com
Wed Feb 28 21:55:15 UTC 2018


Hi Lance,

I'd prefer if 
src/java.sql/share/classes/javax/transaction/xa/package.html was 
replaced by a package-info.java files as opposed to another package.html 
file in the new module.

Thanks,

-Joe


On 2/28/2018 1:22 PM, Lance Andersen wrote:
>> On Feb 28, 2018, at 2:20 PM, Lance Andersen <lance.andersen at oracle.com> wrote:
>>
>> Hi Paul,
>>
>> Thank you for the review.
>>> On Feb 28, 2018, at 1:40 PM, Paul Sandoz <paul.sandoz at oracle.com <mailto:paul.sandoz at oracle.com>> wrote:
>>>
>>> Compatible module refactoring in action!
>>>
>>> Looks good, one comment:
>>>
>>> test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java
>>>
>>> This is not a valid Java source file can you merge the jtreg meta data into XAExceptionTests instead?
>> As we discussed offline, I will change the above file and Driver.java.  I naively assumed this was OK as the change  to add Driver.java was made after I had originally added these tests in 2015.
> http://cr.openjdk.java.net/~lancea/8197533/webrev.01/ has the updated tests
> Best
> Lance
>> Best
>> Lance
>>> Paul.
>>>
>>>> On Feb 28, 2018, at 10:25 AM, Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com><mailto:lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>>> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> This RFR request moves the javax.transaction.xa package out of the java.sql module and into its own module java.transaction.xa.  One of the motivators for this change is due to the fact JSR 907 1.3 MR indicated that the javax.transaction.xa package will be subsumed by Java SE.
>>>>
>>>> There should be no compatibility issues with this change. Any module that `requires java.sql` will continue to have access to the public classes in the javax.transaction.xa package at both compile-time and run-time.
>>>>
>>>>
>>>> The CSR has been approved
>>>>
>>>> The webrev can be found at: http://cr.openjdk.java.net/~lancea/8197533/webrev.00/
>>>>
>>>> Best
>>>> Lance
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif <http://oracle.com/us/design/oracle-email-sig-198324.gif>>>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering
>>>> 1 Network Drive
>>>> Burlington, MA 01803
>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com> <mailto:Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>> <mailto:Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com><mailto:Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>>>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>



More information about the build-dev mailing list