[PATCH] (Title Corrected) Build fails to compile jchuff.c using gcc 4.8.5 on zLinux
adam.farley at uk.ibm.com
Thu Jan 18 11:15:48 UTC 2018
I sent an email to the 2d-dev list yesterday, but I'll respond here as
so you guys know I'm not ignoring you. :)
> This is all correct, thanks David!
> For the official toolchains (basically what Oracle builds with), we very
> much like to keep warnings-as-errors active, because it's a very
> valuable tool in keeping the code healthy. For other toolchains, it
> depends, as David says.
> We have a mechanism for disabling warnings for specific toolchain types
> (gcc, clang, solstudio, visualstudio) on a per library basis. We also
> have the ability to add flags globally for specific toolchain versions
> in configure, in flags.m4. If we want to solve this by disabling a
> warning due to a bug in a specific gcc version, I would recommend the
This is correct. In flags.m4, GCC has a potential
DISABLE_WARNING_PREFIX value of "-Wno-".
Yesterday I posted to 2d-dev and recommended changing
Awt2dLibraries.gmk, which supplies suffixes for that prefix
Basically you change line 494 to this:
DISABLED_WARNINGS_gcc := clobbered array-bounds, \
This puts a -Wno-array-bounds on the gcc compile command for
jchuff.c, thereby ignoring the error-warning I'm seeing.
I ran a build to confirm this works. It did, and the build completed
without further errors.
This fix, if accepted, means --disable-warnings-as-errors will not be
in future zLinux compiles using this gcc (which, as David points out, is
gcc version on the build list).
Just "bash ./compile" and "make all". Simples!
Please send future responses through my email to the 2d-dev list.
Thanks for your time. :)
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
More information about the build-dev