RFR: 8196197 - Enable the make system to calculate concurrency for JDK tests

Tim Bell tim.bell at oracle.com
Fri Jan 26 23:29:48 UTC 2018


Code motion (in Makefiles)...

Looks good to me as well.

Tim

On 01/26/18 14:49, Erik Joelsson wrote:
> This looks good to me.
>
> Note to other reviewers. This change only applies when concurrency isn't
> being set by some other entity. Other entities include the top level
> makefiles (typically when running "make test TEST=<jtreg group>") or by
> setting CONCURRENCY=<foo> on the make command line. The reason for this
> change is to have the test makefiles themselves provide reasonable
> defaults, which is needed when running in our distributed internal test
> system. The neat thing about this implementation is the ability to scale
> concurrency with a relative number using the concurrency factor.
>
> /Erik
>
>
> On 2018-01-26 14:44, Christian Tornqvist wrote:
>> Please review this small change that makes the JDK make test target
>> use the same method for calculating jtreg concurrency as Hotspot.
>> Verified locally and in Mach5.
>>
>> Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8196197/webrev.00/
>> <http://cr.openjdk.java.net/~ctornqvi/webrev/8196197/webrev.00/>
>>
>> Thanks,
>> Christian
>



More information about the build-dev mailing list