RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

David Holmes david.holmes at oracle.com
Thu Nov 1 23:16:20 UTC 2018


Hi Igor,

There's no point having empty test_log macros that do nothing. The macro 
and all uses should just be deleted ... unless you plan on adding some 
other form of logging for this?

Thanks,
David

On 2/11/2018 7:15 AM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html
>> 174 lines changed: 0 ins; 170 del; 4 mod;
> 
> Hi all,
> 
> could you please review this small clean up which removes ExecuteInternalVMTests and VerboseInternalVMTests flags and related make targets and tests?
> 
> 8177708[1-3] is to convert the last of internal vm tests, so the whole InternalVMTests can be removed.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8213058
> webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html
> 
> testing: tier1, build all regular platforms
> [1] https://bugs.openjdk.java.net/browse/JDK-8177708
> [2] http://cr.openjdk.java.net/~iignatyev//8177708/webrev.00/index.html
> [3] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-October/030633.html
> 
> Thanks,
> -- Igor
> 


More information about the build-dev mailing list