RFR(S): remove ExecuteInternalVMTests and VerboseInternalVMTests flags

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Nov 2 18:36:54 UTC 2018


> 2 nov. 2018 kl. 18:03 skrev Igor Ignatyev <igor.ignatyev at oracle.com>:
> 
> Hi Magnus,
> 
>> You still need to fix FindTests.gmk, though.
> thanks for spotting that. is [*] enough, or did I miss something else?

This looks enough. Thanks!

/Magnus

> 
> -- Igor
> 
> [*]
>> diff -r c6d128f60997 make/common/FindTests.gmk
>> --- a/make/common/FindTests.gmk Thu Nov 01 16:33:43 2018 -0700
>> +++ b/make/common/FindTests.gmk Fri Nov 02 10:02:22 2018 -0700
>> @@ -79,7 +79,7 @@
>> ALL_NAMED_TESTS += $(addprefix make-, $(MAKE_TEST_TARGETS))
>> 
>> # Add special tests
>> -ALL_NAMED_TESTS += hotspot-internal failure-handler make
>> +ALL_NAMED_TESTS += failure-handler make
>> 
>> ################################################################################
> 
> 
>> On Nov 2, 2018, at 1:27 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>> 
>> 
>>> On 2018-11-02 00:37, Igor Ignatyev wrote:
>>> on a second though, removing these macros isn't that big, here is an incremental webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1 <http://cr.openjdk.java.net/~iignatyev//8213058/webrev.0-1/index.html>. besides removing test_log, it also include fixes in build and doc needed due to rebasing.
>>> 
>>> Erik, could you please re-review build changes?
>>> 
>>> http://cr.openjdk.java.net/~iignatyev//8213058/webrev.01/ <http://cr.openjdk.java.net/~iignatyev//8213058/webrev.01/> is the whole webrev.
>> 
>> Sorry, I missed your updated webrev. You still need to fix FindTests.gmk, though.
>> 
>> /Magnus
>> 
>> 
>> 
>>> 
>>> Thanks,
>>> -- Igor
>>> 
>>> 
>>>> On Nov 1, 2018, at 4:23 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>>> 
>>>> Hi David,
>>>> 
>>>> removing usage of test_log will just mix "unneeded" changes w/ this clean up. as TestReservedSpace_test, TestReserveMemorySpecial_test, TestVirtualSpace_test, and TestMetaspaceUtils_test are to be removed by 8213269[*], I don't think we need to pay much attention to their code.
>>>> 
>>>> [*] https://bugs.openjdk.java.net/browse/JDK-8213269 <https://bugs.openjdk.java.net/browse/JDK-8213269>
>>>> 
>>>> -- Igor
>>>> 
>>>>> On Nov 1, 2018, at 4:16 PM, David Holmes <david.holmes at oracle.com> wrote:
>>>>> 
>>>>> Hi Igor,
>>>>> 
>>>>> There's no point having empty test_log macros that do nothing. The macro and all uses should just be deleted ... unless you plan on adding some other form of logging for this?
>>>>> 
>>>>> Thanks,
>>>>> David
>>>>> 
>>>>>> On 2/11/2018 7:15 AM, Igor Ignatyev wrote:
>>>>>> http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html
>>>>>>> 174 lines changed: 0 ins; 170 del; 4 mod;
>>>>>> Hi all,
>>>>>> could you please review this small clean up which removes ExecuteInternalVMTests and VerboseInternalVMTests flags and related make targets and tests?
>>>>>> 8177708[1-3] is to convert the last of internal vm tests, so the whole InternalVMTests can be removed.
>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8213058
>>>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html
>>>>>> testing: tier1, build all regular platforms
>>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8177708
>>>>>> [2] http://cr.openjdk.java.net/~iignatyev//8177708/webrev.00/index.html
>>>>>> [3] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-October/030633.html
>>>>>> Thanks,
>>>>>> -- Igor
>> 
> 



More information about the build-dev mailing list