RFR[XS]: JDK-8213414 Fix incorrect copy constructors in hotspot

David Holmes david.holmes at oracle.com
Wed Nov 7 22:39:22 UTC 2018


FTR: This trivial fix caused test carnage and was backed out under 
JDK-8213487.

David

On 7/11/2018 4:28 AM, Kim Barrett wrote:
>> On Nov 6, 2018, at 6:55 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>
>>> On Nov 6, 2018, at 6:16 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>>>
>>> In JDK-8211073, an attempt was made to add -Wextra to hotspot. That patch was not accepted at the time being, but it did dig out some bugs in the code.
>>>
>>> While we await JDK-8211073 to be included in the code base (so -Wextra is always on), we can at least fix the bugs it found in some copy constructors.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8213414
>>> WebRev: http://cr.openjdk.java.net/~ihse/JDK-8213414-fix-hotspot-copy-constructors/webrev.01
>>>
>>> /Magnus
>>
>> Looks good.
> 
> … and trivial.
> 


More information about the build-dev mailing list