[PATCH] JDK-8167368 Leftover: get_source.sh in build documentation

Erik Joelsson erik.joelsson at oracle.com
Tue Nov 13 18:30:30 UTC 2018


Good catch, that should indeed be corrected. I would also remove the 
"all repositories" part. Something like:

"Run `hg pull -u` to make sure you have the latest changes."

/Erik

On 2018-11-12 12:45, Sergey wrote:
> Hi,
>
> I'm not sure if that's the right mailing list, however, I'll try.
> Recently, when I was taking a closer look at build documentation:
> * doc/building.html
> * doc/building.md
>
> I've noticed there get_source.sh being mentioned. I believe that's a
> leftover of JEP-296 Consolidate JDK Forest into a Single Repository.
> I've made a trivial patch and want to contribute it. Please find it inlined
> below.
>
> Thanks,
> Sergei
>
> diff --git a/doc/building.html b/doc/building.html
> --- a/doc/building.html
> +++ b/doc/building.html
> @@ -784,7 +784,7 @@
>   <p>Here are a suggested list of things to try if you are having unexpected
> build problems. Each step requires more time than the one before, so try
> them in order. Most issues will be solved at step 1 or 2.</p>
>   <ol type="1">
>   <li><p>Make sure your forest is up-to-date</p>
> -<p>Run <code>bash get_source.sh</code> to make sure you have the latest
> version of all repositories.</p></li>
> +<p>Run <code>hg pull -u</code> to make sure you have the latest version of
> all repositories.</p></li>
>   <li><p>Clean build results</p>
>   <p>The simplest way to fix incremental rebuild issues is to run <code>make
> clean</code>. This will remove all build results, but not the configuration
> or any build system support artifacts. In most cases, this will solve build
> errors resulting from incremental build mismatches.</p></li>
>   <li><p>Completely clean the build directory.</p>
> diff --git a/doc/building.md b/doc/building.md
> --- a/doc/building.md
> +++ b/doc/building.md
> @@ -1310,7 +1310,7 @@
>
>    1. Make sure your forest is up-to-date
>
> -    Run `bash get_source.sh` to make sure you have the latest version of
> all
> +    Run `hg pull -u` to make sure you have the latest version of all
>       repositories.
>
>    2. Clean build results


More information about the build-dev mailing list