[PATCH] JDK-8167368 Leftover: get_source.sh in build documentation

Erik Joelsson erik.joelsson at oracle.com
Thu Nov 15 16:56:38 UTC 2018


Hello Sergey,

On 2018-11-15 07:41, Sergey wrote:
> Hi Erik, David,
>
> Thanks for review comments! I've almost addressed them,
> however, I have a question worth asking before finalizing a patch.
>
> At the *building.md:1396* [1] (as well as in it's html alter-ego) there's
> a section:
>
> >### Setting Up a Forest for Pushing Changes (defpath)
>
> I believe it is obsolete and could be safely deleted, or am I missing
> something?
>
The defpath part is not obsolete, but "forest" -> "repository" should 
probably be applied to the whole file. The last section about "trees" is 
certainly obsolete however.

> And one more thing about the patches themselves. As
> patches aren't that compact anymore, should I send updated
> diffs for *building.md* && *building.html* in the separate
> mails, or it will be fine if I just inline them alltogether?
>
As long as you are generating the html version using "make 
update-build-docs" (for which you need pandoc, preferably version 
1.17.2), we don't need to see the html version. It's not meant to be 
edited by hand.

Btw, have you signed the OCA?

/Erik

> Thanks,
> su -
>
> [1] 
> http://hg.openjdk.java.net/jdk/sandbox/file/a2413ed39eff/doc/building.md#l1396 
>


More information about the build-dev mailing list