[8u] RFR: 8212110: Build of saproc.dll broken on Windows 32 bit after JDK-8210647

Severin Gehwolf sgehwolf at redhat.com
Fri Nov 16 08:53:21 UTC 2018


Hi Alex,

Hi Alex,

On Fri, 2018-11-16 at 00:32 +0000, Alex Kashchenko wrote:
> Hi Severin
> 
> On 11/15/2018 07:39 PM, Erik Joelsson wrote:
> > Looks good to me.
> > 
> > /Erik
> > 
> > On 2018-11-15 11:31, Severin Gehwolf wrote:
> > > Hi,
> > > 
> > > When the SA optimization fix got backported to JDK 11 a build issue on
> > > Windows 32 bit was discovered by SAP. This would be the JDK 8
> > > equivalent for the old build system. Note that the JDK 8 build still
> > > uses GZ which is deprecated since at least Visual Studio 2012[1]. So
> > > I've replaced it with RTC1. This backport patch depends on [2] which
> > > got reviewed already.
> > > 
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8212110
> > > webrev: 
> > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.02/
> 
> In this line:
> 
> SA_CFLAGS = $(SA_CFLAGS) -ZI
> 
> "ZI" should be changed to "Zi", otherwise it fails on fastdebug and 
> release (not compatible with O2).

Nice catch! How about this?

http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8212110/jdk8/webrev.03/

Thanks,
Severin



More information about the build-dev mailing list