RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

Volker Simonis volker.simonis at gmail.com
Fri Nov 16 09:23:41 UTC 2018


On Thu, Nov 15, 2018 at 5:31 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 11/15/2018 05:06 PM, Volker Simonis wrote:
> > can I please have a review for the following small change:
> >
> > http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/
>
> *) I tested it on platform without libxrandr-dev installed, and configure reported the failure
> appopriately.
>

Thanks for testing!

> *) Indent looks off at L2207 here:
>
> 2205 static char *get_output_screen_name(JNIEnv *env, int screen) {
> 2206 #ifdef _AIX
> 2207         return NULL;
> 2208 #else
> 2209     if (!awt_XRRGetScreenResources || !awt_XRRGetOutputInfo) {
>

You're right. Fixed it.

Thank you and best regards,
Volker

>
> Thanks,
> -Aleksey
>


More information about the build-dev mailing list