<AWT Dev> RFR(XS): 8214120: [REDO] Fix sun.awt.nativedebug on X11 platforms

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Nov 21 12:24:40 UTC 2018


On 2018-11-20 18:13, Volker Simonis wrote:

> Hi,
>
> so here's a reworked version of my previous change:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2018/8214120/
> https://bugs.openjdk.java.net/browse/JDK-8214120
Changes look good to me.

I also started an internal test which is a bit more thorough than 
jdk-submit just to be sure; if you want to you can wait with pushing 
this until it comes out clear. (Later today but I might not be able to 
check it until tomorrow.)

Normally I'd say you don't need to comment on why you're exporting 
functions, but in this x11_awt mess I agree it's helpful.

/Magnus
>
> In addition to my initial change (which unfortunately broke the
> Solaris build) the new version has to JNIEXPORT the following methods
> from libawt.so otherwise they won't be visible in libawt_xawt.so on
> some platforms which make symbols local by default (e.g. Solaris):
>
> DAssert_Impl
> DTrace_PrintFunction
> DTrace_VPrint
> DTrace_VPrintln
>
> Local tests on Linux/AIX and Solaris succeeded. The patch is currently
> building in the submit repo.
>
> Thank you and best regards,
> Volker



More information about the build-dev mailing list