RFR 4947890 : Minimize JNI upcalls in system property initialization
erik.joelsson at oracle.com
Tue Nov 27 21:40:24 UTC 2018
This looks good to me.
On 2018-11-27 13:00, Roger Riggs wrote:
> Updated webrev:
> - Updated defaults for VENDOR, VENDOR_URL, VENDOR_URL_BUG to:
> - Added Brent's suggestion to verify FIXED_LENGTH in the test.
> - Ensure that configure passes the --vendor-... arguments through to
> initialize the system properties.
> Thanks to all the reviewers.
> On 11/26/2018 06:12 PM, Brent Christian wrote:
>> On 11/19/18 3:37 PM, Roger Riggs wrote:
>>>> Raw::xxx_NDX are initialized to 1 + previous_NDX. It's a general
>>>> good approach to increment the index but I find it error-prone and
>>>> hard to catch mistake since the (adjacent) variable names look
>>>> so alike. Perhaps some form of verification or assertion to ensure
>>>> the indices are correctly initialized.
>>> Added a test that uses reflection to verify the uniqueness and
>> The test says:
>> * Check that the Raw._*_NDX indexes are sequential
>> and followed by the FIXED_LENGTH value.
>> though the code does not verify that FIXED_LENGTH is the final
>> value. I don't know that it's all that important to do, but I
>> thought I'd point it out.
More information about the build-dev